Ticket #46 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

Make random forest face recognition Fawkes compliant

Reported by: tim Owned by: AllemaniACs
Priority: major Milestone:
Component: Fawkes Version:
Keywords: Cc:
Git Branch:

Description

The current version of the extremely random forest face recognition code doesn't fit well into the current Fawkes/FireVision universe. Some problems that have to be addressed:

  • different file naming schemes
  • custom namespaces that have not very useful names
  • Non-compliant standard headers
  • non-compliant deflectors
  • uses oldStyle() instead of new_style()
  • Documentation in header
  • Parameters are not documented, I don't know why doxygen does not err about that but the documentation is far from being acceptable.
  • Documentation does not use JavaDoc? style (@param instead of \param)
  • Dates in headers are not as required (poses problem for automatic parsing)
  • code has many overlong lines
  • code uses superfluous this-> where not necessary
  • The CommonHeaders?.hh has to go away, almost certainly harms compilation performance
  • Parameters need to be runtime accessible, a whole bunch of defines is not a good way to configure the algorithm

In general looks as if it would benefit from a review and cleanup. There is more than written here but after this I stopped looking.

Change History

Changed 3 years ago by tim

  • status changed from new to closed
  • resolution set to fixed

It has been made close-to Fawkes compliant. What remains to be done is a refactoring cycle to clean up the code and make it easier to read. But everything that had to be done for this particular ticket has happened, so closing.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Subscriber, Participant

  • Fawkes Trac List(Always)
  • Tim Niemueller(Reporter, Participant)