Ticket #62 (closed enhancement: implemented)

Opened 4 years ago

Last modified 2 years ago

Make FawkesNetworkClient::enqueue() consume message

Reported by: tim Owned by: tim
Priority: major Milestone: 0.4
Component: Fawkes Version:
Keywords: Networking Cc:
Git Branch: timn/fnc-consume

Description

Currently FawkesNetworkClient::enqueue() does not unref() the enqueued message after it has been sent. This means that each application that uses enqueue() has to unref() the message by itself.

Since the typical use case is that the message is unref()'ed immediately after it has been sent the semantics of enqueue() should be changed to do this unref() already. To get the old behavior the message can be ref()'ed before enqueue()'ing.

Since this change needs to look over the whole software to see where changes need to be made I postpone this until after China.

Change History

Changed 2 years ago by tim

Reassigning to milestone 0.4.

Changed 2 years ago by tim

  • milestone changed from 0.3 to 0.4

Changed 2 years ago by tim

  • status changed from new to accepted
  • version set to 0.3

Changed 2 years ago by tim

  • status changed from accepted to reviewing
  • gitbranch set to timn/fnc-consume
  • version 0.3 deleted

Changed 2 years ago by tim

  • status changed from reviewing to closed
  • resolution set to implemented
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Subscriber, Participant

  • Fawkes Trac List(Always)
  • Tim Niemueller(Reporter, Owner, Participant)