Ticket #152 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

"tabletop-objects" vs "tabletop_objects", YAML config differs

Reported by: bahram Owned by: bahram
Priority: minor Milestone:
Component: Fawkes Version:
Keywords: Cc:
Git Branch:

Description

The entry for the tabletop-objects plugin is errorneously written with an underscore "tabletop_objects" in the file "50_tabletop_objects.yaml", whereas the plugin expects "tabletop-objects".

The fix should be easy, however, I'm not sure about which way is prefered. If we change the value in the YAML file, should I also rename the file itself to become "50_tabletop-objects"? Or should the plugin itself be renamed to use underscores?

Change History

comment:1 Changed 2 years ago by tim

I'd change the config file to have the dash version. I'd keep the file name as is though, there is no relation from config to file path directly.

comment:2 Changed 2 years ago by tim

  • Version 0.4.2 deleted

comment:3 Changed 2 years ago by tim

  • Owner changed from tim to bahram
  • Status changed from new to assigned

comment:4 Changed 2 years ago by tim

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in master branch.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Subscriber, Participant

  • Bahram Maleki-Fard(Reporter, Owner)
  • Fawkes Trac List(Always)
  • Tim Niemueller(Participant)